-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An event is upcoming if it hasn't finished yet #9980
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The naming here is a bit misleading -- we want upcoming or in-progress events to show under the 'Events' header, because if an event isn't upcoming it moves straight to 'Past events'. This is causing issues for the Land Bodies Ecology Festival, which is already showing Day 1 under 'Past events' even though it's still happening today.
Size Change: 0 B Total Size: 1.09 MB ℹ️ View Unchanged
|
jamieparkinson
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The naming here is a bit misleading -- we want upcoming or in-progress events to show under the 'Events' header, because if an event isn't upcoming it moves straight to 'Past events'.
This is causing issues for the Land Bodies Ecology Festival, which is already showing Day 1 under 'Past events' even though it's still happening today.
See Slack discussion: https://wellcome.slack.com/archives/C8X9YKM5X/p1687427559655459