Ensure that test failures are reported by Buildkite #7677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
February 15, 2022 14:02
jamieparkinson
approved these changes
Feb 18, 2022
|
Size Change: +8 B (0%) Total Size: 1.2 MB ℹ️ View Unchanged
|
paul-butcher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who is this for?
Developers
What is it doing for them?
This fixes #7662 and also some of the test failures that that issue was masking.
When tests fail, the build pipeline will now show that they have failed.
I have set content tests to be a soft failure, because of changes underway around the use of raw prismicDocuments elsewhere. So a red light will show on the step, but the build will still pass.
See https://buildkite.com/wellcomecollection/experience/builds/5787