Repetitive structures #6229
Merged
Repetitive structures #6229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # common/views/components/ViewerStructuresPrototype/ViewerStructuresPrototype.tsx
| acc.previousLabel === structure.label && | ||
| firstCanvasIndex === acc.previousLastCanvasIndex + 1 | ||
| ) { | ||
| acc.groupedArray[acc.groupedArray.length - 1].canvases.push( |
There was a problem hiding this comment.
Prefer concat to be less mutable?
davidpmccormick
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When lots of the works were digitised, structures with multiple pages such as table of contents were created individually, rather than as a single structure with a range of pages.
This means we will often display repetitive links to the essentially the same thing.
Until we can improve the data at source, this function groups structures that have the same label attached to consecutive pages into a single structure.
Before:
After:
