Adds a simple healthcheck endpoint to the identity app #10617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
rcantin-w
approved these changes
Jan 26, 2024
|
Size Change: 0 B Total Size: 876 kB
ℹ️ View Unchanged
|
This was referenced Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This change is part of #10545 and adds a healthcheck endpoint to the content app so we can really check the health of the app before it is deployed. At present the healthcheck terminates at the nginx container so during deployment (and normal running) we don't check if the app has properly started.
Same change for the content app: #10612
See https://github.com/wellcomecollection/platform-infrastructure/blob/main/images/dockerfiles/nginx/frontend.nginx.conf#L24
Note
This will require a further change to remove the nginx config that fields the healthcheck request there.
How to test?
How can we measure success?
No downtime during deployments resulting in a better experience for visitors to the site, and fewer errors that we cannot effectively respond to in the alerts channel. Deployments that really check if the app is running avoiding situations where we deploy a broken service.