Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images routing with modals #8350

Closed
rcantin-w opened this issue Aug 31, 2022 · 2 comments · Fixed by #8351 or #9962
Closed

Images routing with modals #8350

rcantin-w opened this issue Aug 31, 2022 · 2 comments · Fixed by #8351 or #9962
Assignees
Labels
Bug 🐛 A change made to ensure a feature is maintaining the baseline KPIs. catalogue 📚 Wrangling data from the API

Comments

@rcantin-w
Copy link
Contributor

rcantin-w commented Aug 31, 2022

Based on this Slack conversation

  1. Access /images
  2. Click an image, opening a modal
  3. Try to go back using the browser function
  4. If URL is still /image, the modal stays open
  5. And it's always the latest accessed image.

This behaviour should change so users could share specific URLs or access previous images they've clicked on as currently they "lose" them forever when browsing from one related image to the next.

@rcantin-w rcantin-w self-assigned this Aug 31, 2022
Repository owner moved this from In Progress to Done in Digital platform Sep 1, 2022
@rcantin-w rcantin-w moved this from Done to Next in Digital platform Sep 2, 2022
@rcantin-w
Copy link
Contributor Author

Bringing this back:

Reverting the changes (#8350, original PR here) brings back the navigational "bug", but it wasn't a good fix. It introduced a new bug, clearing query parameters like filters. The ticket will be brought back and different options explored, but as this not good behaviour, better to revert for now to the old one.

We'll need to find a different way to go about this!

@rcantin-w rcantin-w moved this from Next to Backlog in Digital platform Sep 14, 2022
@rcantin-w rcantin-w reopened this Nov 2, 2022
@rcantin-w rcantin-w moved this from Backlog to Next in Digital platform Nov 2, 2022
@rcantin-w rcantin-w removed their assignment Nov 2, 2022
@rcantin-w rcantin-w moved this from Next to Backlog in Digital platform Nov 9, 2022
@rcantin-w
Copy link
Contributor Author

Flagged as an issue again in a New Search feedback session

Open the image modal on /search, then click a visually similar image – the page behind you jumps to the top of the page, which is both annoying and potentially a minor accessibility issue

This happens everywhere and is due to the images being "linked" to "#". Doing this ticket right should ensure fixing the above as well.

@jtweed jtweed moved this from Backlog to Next in Digital platform Mar 14, 2023
@AMBacelar AMBacelar mentioned this issue Apr 14, 2023
@AMBacelar AMBacelar self-assigned this Jun 20, 2023
@AMBacelar AMBacelar moved this from Next to In progress in Digital platform Jun 20, 2023
@AMBacelar AMBacelar linked a pull request Jun 20, 2023 that will close this issue
@AMBacelar AMBacelar moved this from In progress to Ready for review in Digital platform Jun 26, 2023
@github-project-automation github-project-automation bot moved this from Ready for review to Done in Digital platform Jun 26, 2023
@pollecuttn pollecuttn moved this from Done to Archive in Digital platform Jul 5, 2023
@pollecuttn pollecuttn removed the status in Digital platform Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 A change made to ensure a feature is maintaining the baseline KPIs. catalogue 📚 Wrangling data from the API
Projects
None yet
2 participants