If the ingest worker tries to update a non-existent ingest, retry #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s lots of updates" a85eca4
This is more accurate than the current status code, HTTP 409 Conflict.
I was trying to debug an issue with an ingest tracker test where applying an update would return a UpdateToNonExistentIngestError. I wanted to check the ingest really was being stored correctly. (The test was fixed in the previous commit)
alexwlchan
force-pushed
the
allow-multi-ingest-tracker-updates
branch
from
89a5ca5
to
475aa67
Compare
alexwlchan
commented
Sep 18, 2020
Comment on lines
-40
to
-43
| case class IngestStoreUnexpectedError(e: Throwable) extends IngestStoreError { | ||
|
|
||
| case class IngestStoreUnexpectedError(storageError: StorageError) | ||
| extends IngestStoreError { | ||
| override def toString: String = { | ||
| s"IngestStoreUnexpectedError: ${e.toString}" |
There was a problem hiding this comment.
Discarding the outer wrapper meant the Throwable we got was sometimes null, which is unhelpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes wellcomecollection/platform#4781
This introduces a new status code in the ingest tracker API. If you do a
PATCH /ingest/{id}and that ingest doesn't exist yet, you get an HTTP 404 Not Found instead of HTTP 409 Conflict. This can occur if there's a DynamoDB consistency issue that means the DynamoTracker can't find the ingest.The tracker client turns this status code into a new error type, and the ingest worker treats this error as non-deterministic.
Plus a couple of other changes to make this code easier to debug if we have other issues in future.