-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report evictions in buildkite #233
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
6ed06c7
put the steps in groups
paul-butcher 13e79aa
run evicted in buildkite
paul-butcher 113b886
annotate with any found warnings
paul-butcher 185bf20
annotate with any found warnings
paul-butcher 87ee71a
do not annotate
paul-butcher a380883
quieten composeNoBuild warning
paul-butcher df48a5d
try soft failing on warnings
paul-butcher 00502c6
try soft failing on warnings
paul-butcher 9aeddbe
shift eviction reporter to sh file
paul-butcher a371444
quieten release warning
paul-butcher 200e2a4
rename new step
paul-butcher 95bc72e
allow script to actually run
paul-butcher 7197fed
allow script to actually run
paul-butcher 99d49fc
quieten release warning
paul-butcher b7543d7
quieten release warning
paul-butcher c5f022a
quieten release warning
paul-butcher 4c83c22
let it finish
paul-butcher 69f7cde
improve warning detection
paul-butcher 5c22f2f
improve warning detection
paul-butcher 8db059b
check that soft fail is set correctly
paul-butcher 15c1660
check that soft fail is set correctly
paul-butcher ca9916f
report holistic evictions
paul-butcher 000d6de
fix typo
paul-butcher 16291b6
report holistic evictions
paul-butcher 025d0ba
report holistic evictions
paul-butcher 6fdf552
can't use matrix in artifact paths
paul-butcher a186bf2
wrong path
paul-butcher 38cc68a
fix typo
paul-butcher cb26304
improve output
paul-butcher 93fc929
try bullets
paul-butcher 5c4135e
add summary note
paul-butcher 136ed43
improve spacing
paul-butcher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,3 +17,6 @@ metals.sbt | |
|
||
.terraform | ||
terraform.plan | ||
|
||
# output from code checkers, tests etc. | ||
.reports |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
RELEASE_TYPE: patch | ||
internal-only build improvements |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
mkdir -p .reports | ||
REPORT_FILE=".reports/evicted_${1}" | ||
./builds/run_sbt_task_in_docker.sh "project $1" "evicted" | grep '^\[warn\]' | tee $REPORT_FILE | ||
WARNING_COUNT=$(cat $REPORT_FILE | grep -E '^\[warn\]\s+\*' | wc -l ) | ||
if [ "$WARNING_COUNT" != "0" ] | ||
then | ||
echo "found $WARNING_COUNT suspected binary incompatible eviction(s)" | ||
exit 2 | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# Intended to be run after producing eviction reports with report_sbt_evictions.sh | ||
echo "# Suspected binary incompatible evictions across all projects (summary)" | ||
cat .reports/evicted_* | grep -E '^\[warn\]\s+\*' | sed 's/.*\*/*/' | sort | uniq | ||
echo "" | ||
echo "See individual _evictions_ stages for more detail" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 pipes? that's insane!