Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the SBT version from 1.4.1 to 1.9.8 #2526

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Bump the SBT version from 1.4.1 to 1.9.8 #2526

merged 2 commits into from
Jan 24, 2024

Conversation

kenoir
Copy link
Contributor

@kenoir kenoir commented Jan 23, 2024

What does this change?

This is another instance of wellcomecollection/catalogue-api#737, needed to compile the app on new Macs. Interestingly this also requires a circe bump to prevent this failure when coupled with the scala-libs update.

How to test?

The most recent version (1.9.8) of sbt seems to work with this project, so upgrading.

  • Build and test locally, does it succeed?
  • Does this PR get a green tick when running in CI?

How can we measure success?

People working on this project with M1 macs can build and test it.

@kenoir kenoir requested a review from a team January 23, 2024 17:39
@kenoir kenoir merged commit 4ce99a4 into main Jan 24, 2024
1 check passed
@kenoir kenoir deleted the rk/bump-sbt-version branch January 24, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants