Do not try to add parents to simple paths #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-butcher
changed the title
paul-butcher
commented
Dec 18, 2023
Comment on lines
+104
to
+118
| it("does not add a parent to a root-only path") { | ||
| // When the requested path consists of a single node, it is the root of its own tree, | ||
| // and cannot have a parent. | ||
| // An earlier iteration of this service would get confused by the trailing slash in | ||
| // a path in a different tree. | ||
| val works: List[Work[Merged]] = List( | ||
| work(path = "parent"), | ||
| work(path = "a/completely/different/tree/") | ||
| ) | ||
| withLocalMergedWorksIndex { | ||
| index => | ||
| insertIntoElasticsearch(index, works: _*) | ||
| whenReady(service(index).getParentPath("parent")) { | ||
| _ shouldBe empty | ||
| } |
There was a problem hiding this comment.
This is the only actual addition to this file. The rest is IntelliJ deciding it didn't like the formatting. Sorry about that.
kenoir
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem seen here: #2500
(See this comment for details)