Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Arabic [Karshuni] as a language option #2113

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Add Arabic [Karshuni] as a language option #2113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b91ade8
Add Arabic [Karshuni] as a language option
paul-butcher Jun 6, 2022
9779c89
tidy whitespace
paul-butcher Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...r/transformer_tei/src/main/scala/weco/pipeline/transformer/tei/data/TeiLanguageData.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ object TeiLanguageData extends Logging {
// This means we'll display the most accurate label on the individual work pages,
// but these works will filter/aggregate alongside the "parent" language.
//
case ("ar", "Arabic [Karshuni]") =>
customLanguage("Arabic", overrideLabel = "Arabic [Karshuni]")
case ("egy", "Ancient Egyptian") =>
customLanguage("Egyptian", overrideLabel = "Ancient Egyptian")
case ("egy", "Egyptian (Ancient)") =>
Expand Down
12 changes: 12 additions & 0 deletions ...mer/transformer_tei/src/test/scala/weco/pipeline/transformer/tei/TeiTransformerTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,18 @@ class TeiTransformerTest
)
}

it("extracts languages with different labels to MARC ") {
val work = transformToWork(filename = "/Batak_36801.xml")(
id = "Wellcome_Batak_36801"
)
// The document contains <textLang mainLang="bbc">Toba-Batak</textLang>
// The MARC code for that language is btk and the MARC label is Batak
// The extraction retains the label from the TEI document, but replaces the code
work.value.data.languages shouldBe List(
Language(id = "btk", label = "Toba-Batak")
)
}

it("extracts languageNotes if it cannot parse the languages") {
val work = transformToWork(filename = "/Indic_Alpha_978.xml")(
id = "Wellcome_Alpha_978"
Expand Down