Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some more query tweaks #731

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Some more query tweaks #731

merged 5 commits into from
Dec 7, 2023

Conversation

jamieparkinson
Copy link
Contributor

paul-butcher
paul-butcher approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@paul-butcher paul-butcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing wrong with having short _names in the query parts, and it can help with understanding how a particular term was matched. (not suggesting that you put them back in right now, just that it might be good to have them).

@jamieparkinson
Copy link
Contributor Author

Good point, I will put them back

@jamieparkinson jamieparkinson merged commit ceb8f34 into main Dec 7, 2023
1 check passed
@jamieparkinson jamieparkinson deleted the final-query-tweaks branch December 7, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-butcher paul-butcher paul-butcher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamieparkinson @paul-butcher