Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image query with vector two #703

Merged
merged 23 commits into from
Sep 13, 2023
Merged

Image query with vector two #703

merged 23 commits into from
Sep 13, 2023

Conversation

agnesgaroux
Copy link
Contributor

  • Reverts the reverted colour search changes
  • Fixes rounding issue when creating colour filter queryVector
  • Adds test combining query and knn colour search
    not sure it's in the right place
    please check whether the expected results for combines free test query and knn search in search/src/test/scala/weco/api/search/images/ImagesFiltersTest.scala is what we actually want:
    blue foot and pretty blue foot come first,
    3rd is the red foot because it's a closer match for foot even though it's not blue
    4th in line is less foot but more blue, and come after the red foot because foot takes precedence
    5th is no foot but it's blue
    6th is not foot nor blue

@agnesgaroux agnesgaroux merged commit 040a33a into main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants