remove optional tcp healthcheck, no longer used

wellcomecollection · Jan 25, 2024 · e72e611 · e72e611
1 parent cb73165
commit e72e611
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 23 deletions.
diff --git a/terraform/modules/service/target_group.tf b/terraform/modules/service/target_group.tf
@@ -15,22 +15,10 @@ resource "aws_lb_target_group" "tcp" {
   # updated service.  Reducing this parameter to 90s makes deployments faster.
   deregistration_delay = 90
 
-  dynamic "health_check" {
-    for_each = var.tcp_healthcheck == false ? toset([]) : toset([1])
-
-    content {
-      protocol = "TCP"
-    }
-  }
-
-  dynamic "health_check" {
-    for_each = var.tcp_healthcheck == true ? toset([]) : toset([1])
-
-    content {
-      protocol = "HTTP"
-      path     = var.healthcheck_path
-      matcher  = "200"
-    }
+  health_check {
+    protocol = "HTTP"
+    path     = var.healthcheck_path
+    matcher  = "200"
   }
 }
 

diff --git a/terraform/modules/service/variables.tf b/terraform/modules/service/variables.tf
@@ -73,14 +73,7 @@ variable "app_memory" {
   type = number
 }
 
-variable "tcp_healthcheck" {
-  # TODO: Remove this when all services use HTTP healthcheck
-  type    = bool
-  default = true
-}
-
 variable "healthcheck_path" {
-  # Note: this is only used when tcp_healthcheck is set to false
   type    = string
   default = "/management/healthcheck"
 }