Improve the Buildkite Terraform #5

alexwlchan · 2023-02-10T13:04:00Z

Fix the S3 deprecation warnings from the latest Terraform provider
Add a trailing newline so it stops trying to update our CloudFormation resources (see [Bug]: aws_cloudformation_stack always wants to change templates which (i) do not have a trailing newline and (ii) are greater than 16KB hashicorp/terraform-provider-aws#29342)
Push the common parameters into a common variable

This stops Terraform from trying to repeatedly update this resource.

alexwlchan added 4 commits February 10, 2023 12:50

Remove the Buildkite v5.8.0 YAML file

bf2b588

Remove the Buildkite v5.10.0 YAML file

c052ae0

Fix a bunch of S3 deprecations in the newest Terraform provider

3473b1f

Add a trailing newline to the Buildkite CloudFormation template

47554cf

This stops Terraform from trying to repeatedly update this resource.

alexwlchan changed the title ~~Make Terraform happy again~~ [WIP] Improve the Buildkite Terraform Feb 10, 2023

alexwlchan added 2 commits February 10, 2023 13:06

Pull the common parameters into a shared variable

ba55f94

Push BuildkiteTerminateInstanceAfterJob into the common params

499ab34

alexwlchan changed the title ~~[WIP] Improve the Buildkite Terraform~~ Improve the Buildkite Terraform Feb 10, 2023

Fix the tag pointing to the Terraform configuration

886dbd9

jamieparkinson approved these changes Feb 10, 2023

View reviewed changes

alexwlchan merged commit 6f7fb5b into main Feb 12, 2023

Provide feedback