WIP: experimentally use dupIO #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new token type TkDup for use when encoding, that duplicates the contained closure. This means that encodings can explicitly duplicate thunks that may otherwise end up in the old generation. It isn't obvious to me whether this is enough or whether calling dupIO every time would be better (and whether that might have an unreasonable performance cost).
This was referenced May 18, 2023
|
Closing in favour of #321. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #318. This adds a new token type
TkDupfor use when encoding, that duplicates the contained closure. This means that encodings can explicitly duplicate thunks that may otherwise end up in the old generation. It isn't obvious to me whether this is enough or whether callingdupIOevery time would be better (and whether that might have an unreasonable performance cost).Of course
dupIOisn't yet released, and currently has soundness issues with static closures, so this isn't suitable for merge in any case...