Support GHC 9.2/9.4 and bytesting 0.11 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canonical JSON is not a proper subset of RFC 7159. So for the property 'prop_aeson_canonical', where we check that everything produced as canoncal JSON can be parsed by Aeson (which we assume correctly implements RFC 7159), we have to tweak things to keep us within the common subset of canoncal JSON and RFC 7159. Specifically, canoncal JSON only escapes \ and ", and does not escape any other non-printable characters. So the tweak is to just omit non-printable characters from all strings in this test. Thus we test only within the common subset.
|
@erikd if you're wondering about the fix to do with the escape chars, see the comment on the patch and see: Yes, sadly Canonical JSON is not a proper subset of RFC 7159, and that test was improperly assuming it was (or possibly the QC ASCII string generator didn't previously generate control chars less than char 32, but now does). |
|
Yay, CI all green. Thanks @erikd for setting that up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased and extended version of PR #8 from @erikd.
I've had to make it a new PR since it's now a branch in this repo, rather than Erik's repo fork.
In particular it fixes the broken test that Erik identified.
Lets see what CI says now.