Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big batch #17

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Big batch #17

merged 3 commits into from
Jun 17, 2024

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Jun 13, 2024

No description provided.

@dcoutts dcoutts mentioned this pull request Jun 14, 2024
Copy link
Member

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. It looks like it should do the pipelining in the way I was hoping.

I think we should address the code duplication though.

src/System/IO/BlockIO.hs Outdated Show resolved Hide resolved
src/System/IO/BlockIO.hs Show resolved Hide resolved
, testCase "example_initReadClose" example_initReadClose
, testCase "example_initReadClose 32" $ example_initReadClose 32
, testCase "example_initReadClose 96" $ example_initReadClose 96
, testCase "example_initReadClose 200" $ example_initReadClose 200
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This removes the limit previously imposed on callers to keep their batch
sizes below a limit. Splitting into subbatches, submitting them (in a
pipelined fashion) and combining the results is now done automatically.

This simplifies the interface for users of the library.
@dcoutts dcoutts enabled auto-merge June 17, 2024 13:50
@dcoutts dcoutts added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 3bfff11 Jun 17, 2024
10 checks passed
@dcoutts dcoutts deleted the big-batch branch June 17, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants