UI: text editor - add an input to hide specific text (WEKAPP-373373) #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofa-tata
reviewed
Mar 11, 2024
src/components/TextEditor/components/HideContentInput/HideContentInput.tsx
Outdated
Show resolved
Hide resolved
src/components/TextEditor/components/HideContentInput/HideContentInput.tsx
Show resolved
Hide resolved
mvoloshin0458
force-pushed
the
maxim/text-viewer-input-to-hide-text
branch
from
9fb4de2
to
1736f2b
Compare
sofa-tata
reviewed
Mar 18, 2024
There was a problem hiding this comment.
I guess we need to have side padding as in the Search input for example (same for Tags)
There was a problem hiding this comment.
It will be too difficult to solve this since it is caused by React Select design - they don't make an input with scrolling, but they make input with the size of the text and position it with JS. I will open a ticket for refactoring the tags input and will add this point to it
mvoloshin0458
force-pushed
the
maxim/text-viewer-input-to-hide-text
branch
from
1736f2b
to
1b748d8
Compare
|
@sofa-tata please review the updates. pushed fixes to https://github.com/weka/gohome/pull/1049 |
mvoloshin0458
force-pushed
the
maxim/text-viewer-input-to-hide-text
branch
from
1b748d8
to
5259599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.