Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix raf bug #15

Merged
merged 3 commits into from
Jan 17, 2019
Merged

fix raf bug #15

merged 3 commits into from
Jan 17, 2019

Conversation

majg0
Copy link
Contributor

@majg0 majg0 commented Jan 17, 2019

closes #14

Copy link
Owner

@weizhenye weizhenye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, please do not checkin dist in the commit, dist files will be built in new version.

dist/ass.js Outdated Show resolved Hide resolved
dist/ass.js Outdated Show resolved Hide resolved
dist/ass.js Outdated Show resolved Hide resolved
@weizhenye
Copy link
Owner

I can't get the relevance of this error and your solution, do you have any way to reproduce it?

From your solution, I guess video.play() is called multi times and triggered multi play events, then... I don't know.

Anyway, it should solve some edge cases and I'm OK to merge it.

@majg0
Copy link
Contributor Author

majg0 commented Jan 17, 2019

@weizhenye thanks; fixed

It's probably a bit complex to reproduce.
We have reactive code which triggers rerenders.
It happens rarely when the user is scrubbing the video around timestamp 0.

@weizhenye weizhenye merged commit 17f0108 into weizhenye:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot read property 'currentTime' of null
2 participants