Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PROJ from 6.3.1 to 7.0.0, pyproj from 2.6.0 to 3.0.dev2 #164

Merged
merged 4 commits into from
Sep 22, 2020

Conversation

weiji14
Copy link
Owner

@weiji14 weiji14 commented Sep 22, 2020

Allows us to simplify the lonlat_to_xy code created in #40. Keeping these fundamental projection system tools up to date is a good idea too!

TODO:

Bumping pyproj from 2.6.0 to 3.0.0 allows us to get rid of the __array__ workaround added in be98dde/#40. Also took the opportunity to improve the documentation of the function's input parameters and output results.
@weiji14 weiji14 added the dependencies Pull requests that update a dependency file label Sep 22, 2020
@weiji14 weiji14 self-assigned this Sep 22, 2020
@weiji14 weiji14 mentioned this pull request Sep 22, 2020
4 tasks
Bumps [fiona](https://github.com/Toblerity/Fiona) from 1.8.13.post1 to 1.8.17. Fixes annoying "Unable to open EPSG support file gcs.csv" warning!
- [Release notes](https://github.com/Toblerity/Fiona/releases)
- [Changelog](https://github.com/Toblerity/Fiona/blob/1.8.17/CHANGES.txt)
- [Commits](Toblerity/Fiona@1.8.13.post1...1.8.17)
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 22, 2020

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.82%.

Quality metrics Before After Change
Complexity 1.89 ⭐ 1.67 ⭐ -0.22 👍
Method Length 64.56 🙂 62.33 🙂 -2.23 👍
Working memory 8.22 🙂 8.11 🙂 -0.11 👍
Quality 76.80% 77.62% 0.82% 👍
Other metrics Before After Change
Lines 259 274 15
Changed files Quality Before Quality After Quality Change
deepicedrain/spatiotemporal.py 76.80% ⭐ 77.62% ⭐ 0.82% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
deepicedrain/spatiotemporal.py point_in_polygon_gpu 4 ⭐ 171 😞 13 😞 51.66% 🙂 Try splitting into smaller methods. Extract out complex expressions
deepicedrain/spatiotemporal.py Region.from_gdf 4 ⭐ 96 🙂 14 😞 58.96% 🙂 Extract out complex expressions
deepicedrain/spatiotemporal.py Region.datashade 0 65 🙂 12 😞 70.49% 🙂 Extract out complex expressions
deepicedrain/spatiotemporal.py Region.subset 1 ⭐ 72 🙂 10 😞 72.05% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@weiji14 weiji14 merged commit 3b6925c into master Sep 22, 2020
@weiji14 weiji14 deleted the dependencies/proj7-pyproj3 branch September 22, 2020 12:22
@weiji14 weiji14 added the maintenance 🧰 Keeping things tidy label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance 🧰 Keeping things tidy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant