-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process ICESat-2 ATL11 data up to 20200513 #129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update our ATLAS catalog to include ATL06 data up to and including 20200513, and download about a month and a week's worth of extra data. Note that data from 20200422 to 20200504 is of revision 2 instead of revision 1, hence the changes in the catalog and atl06_play.ipynb script.
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
Get some compression and light datatype goodness, but some bugs still remain!
Went out of my way to reprocess every ATL11 file once more, so this took a while, even with 72 CPU cores instead of 64! No hard numbers because my browser crashed at 73% and I didn't want to stop the `parallel` process, but it still takes about a week. This is a new refresh over 5198b2b. Had to change some glob statements as the output ATL11_*.h5 filename dropped the `v` for version. The 'corrected_h' group is now simply the 'root' group, and I've made sure the correct datatype is stored to Zarr by reading the "ATL11/ATL11_output_attrs.csv" file. The quality_summary name clash is gone, but we now need to convert the 'ATL06_xover_field_list' from binary to str to store to Zarr properly. Reduced more exceptional cases, and only reference ground track 1036 is missing an ATL11 file right now! Also fixed a few style errors DeepCode suggested.
weiji14
force-pushed
the
atl06_20200513_update
branch
from
July 28, 2020 07:19
a2574dd
to
bff7345
Compare
Nothing against longitude and latitude, but we only need one coordinate system for now, and Cartesian x/y calculations are faster than Geographic lon/lat. This is necessary as the ATL11 hdf5 schema now has longitude/latitude as proper coordinates (which is good actually). Also bumped core count in atl11_play.ipynb and atxi_dhdt.ipynb from 64 to 72. so that we can churn through 2 million more points faster!
Sourcery Code Quality Report (beta)❌ Merging this PR will decrease code quality in the affected files by 0.02 out of 10.
Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still 7 ICESat-2 cycles to analyze, but there's 40 extra days to add! See also previous update at #44
Note that this will (hopefully) be the last time I'll do the ATL06_to_ATL11 processing 🤞. The ATL11 schema has changed considerably (see #126), particularly with the removal of the 'corrected_h' group in suzanne64/ATL11#11. This PR is more about updating the scripts to use the new schema, but once the official ATL11 data product comes out, I'll switch to using that instead.
git diff
command to only getATL06_to_ATL11_Antarctica.sh
lines that have changed:TODO:
31830b5
to22bf569
#130 so that we get lots of float32 dtypes and smaller filesizes (One ATL11_*.zarr folder is now ~20MB instead of ~30MB before). See also suzanne64/ATL11@dbc221a! (d3ace2d)Supersedes Downcast ATL11 data variables to lighter dtypes #53:
changedall files, since the datatypes have become lighter (bff7345)References: