Merge pull request #2 from wedevelopnl/fix/child-fields-editable

Child widget fields should now properly propagate to the related widget
wedevelopnl · May 11, 2023 · 9d534ae · 9d534ae
2 parents bb96d7e + 36f7ad7
commit 9d534ae
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/composer.json b/composer.json
@@ -13,7 +13,8 @@
         "silverstripe/cms": "^4.11",
         "dnadesign/silverstripe-elemental": "^4.9",
         "sheadawson/silverstripe-dependentdropdownfield": "^2",
-        "unclecheese/display-logic": "^2.0"
+        "unclecheese/display-logic": "^2.0",
+        "stevie-mayhew/hasoneedit": "^2.0"
     },
     "require-dev": {
         "friendsofphp/php-cs-fixer": "^3.4"

diff --git a/src/Element/ElementWidget.php b/src/Element/ElementWidget.php
@@ -5,6 +5,7 @@
 namespace WeDevelop\ElementalWidget\Element;
 
 use DNADesign\Elemental\Models\BaseElement;
+use SGN\HasOneEdit\HasOneEdit;
 use Sheadawson\DependentDropdown\Forms\DependentDropdownField;
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\Core\Config\Config;
@@ -122,9 +123,15 @@ public function getCMSFields(): FieldList
 
             $widgetFields->removeByName([
                 'Title',
-                'Root.Main',
+                'Main',
             ]);
 
+            // We'll loop over the widget fields to properly set the name so it maps to the relation
+            // instead of trying to edit it on the element itself
+            foreach($widgetFields->dataFields() as $field) {
+                $field->setName('Widget' . HasOneEdit::FIELD_SEPARATOR . $field->getName());
+            }
+
             if ($this->SourcesFromCollection) {
                 $fields->addFieldToTab(
                     'Root.Widget',