Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump symfony/dotenv #137

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Bump symfony/dotenv #137

merged 1 commit into from
Mar 12, 2024

Conversation

nlemoine
Copy link
Contributor

@nlemoine nlemoine commented Mar 9, 2024

Description

At first, I just wanted to bump symfony/dotenv to 7 for users that are on PHP 8.2.

However, some dev dependencies got symfony/dotenv stuck at 6.4.4.

So I bumped them too (vimeo/psalm & symfony/process) to allow symfony/dotenv 7 upgrade.

How has this been tested?

Using your QA workflow here:
https://github.com/nlemoine/wpstarter/actions/runs/8214878478

All unit tests pass.

Types of changes

No noticeable change on the code perspective. But bumping Pslam to the lastest version triggered many errors, which in the end might not be a bad thing. I guess the tool improved over time and spotted more potential errors.

Checklist:

  • My code is tested
  • My code follows the project code style
  • My code has documentation (for new features or changed behavior)

@gmazzap gmazzap merged commit 0573e8a into wecodemore:dev Mar 12, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants