-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Docs: contact part #289
Merged
Merged
Changes from 15 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
01f4552
Change JavaScript code to python, reformat the docs of contact part, …
GaryDu0123 10f6b23
fix a typo
GaryDu0123 bcae93d
fix same typos and missing
GaryDu0123 01b694a
Merge branch 'wechaty:master' into master
GaryDu0123 59c8817
Merge remote-tracking branch 'origin/master'
GaryDu0123 8eefe90
fix same typos and missing
GaryDu0123 f235bbe
replace the wrong link
GaryDu0123 d250de9
replace the wrong link
GaryDu0123 dd51f92
更新修改了Room和ContactSelf类
GaryDu0123 8bf587d
示例方法 -> 实例方法
GaryDu0123 f34eb3a
更改了room文档中的错字以及say的类型, 将message类进行代码替换和翻译, 添加新类, 标注弃用的类
GaryDu0123 2113b05
更新群聊邀请类的文档, 更改room类的missing, message类的markdown文档标注
GaryDu0123 817534e
对极少数方法进行了整理
GaryDu0123 84e640c
修改了变量名
GaryDu0123 530c892
fix a typo
GaryDu0123 892c303
修改了返回值类型, 将一部分camelCase改为snake_case
GaryDu0123 3a61599
provide more clear docs description
GaryDu0123 c109ad9
change the every format of method docs title from xxx.XXX to [async] …
GaryDu0123 707bc1f
Merge branch 'wechaty:master' into master
GaryDu0123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some suggestions:
contactSelf
should becontact_self
that you can change lots of variables. How do you think about it?Coroutine
, please refer to:Coroutine[..., ..., ...]
None | FileBox
which is the program language gramar in ts, it shoule be: Optional[Filebox]There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GaryDu0123 there are some discussion topic in outline comment, we can get deep into discussion about one of topic as sub-comment. eg this comment is the sub-comment about type annotations.
If you can not understand, let use the generated stubfile type annotation in pyi file. For example:
Here is the generated stubfile with
subgen
tools. You can have a detail look. The following code is the example:The suggested command is:
Please feel free to discuss more about this problem.