-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use babel instead of buble #1698
Conversation
Is this faster than buble? |
1.59s for babel vs 0.82s for buble. I think I'd rather be use |
I’m leaning more towards buble because of speed, but I can see it doesn’t make big difference here. What exactly becomes more consistent? |
I don't feel super strongly, but babel has these advantages:
|
Applying JSX transformations exclusively sounds great, but in this case I prefer buble simply because it's faster. I'm fine either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Given that |
This way we can target just the JSX tranformation. We don't use any other cutting edge JS features that require compilation, nor should we in the future.
Thanks for the review, @hicom150. I just rebased this and merged it! |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Inspired by @hicom150's PR #1695, I swapped out
buble
forbabel
.This way we can target just the JSX transformation. We don't use any other cutting edge JS features that require compilation, nor should we in the future.
Is there anything you'd like reviewers to focus on?