Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use babel instead of buble #1698

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Use babel instead of buble #1698

merged 1 commit into from
Nov 18, 2020

Conversation

feross
Copy link
Member

@feross feross commented Sep 15, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

Inspired by @hicom150's PR #1695, I swapped out buble for babel.

This way we can target just the JSX transformation. We don't use any other cutting edge JS features that require compilation, nor should we in the future.

Is there anything you'd like reviewers to focus on?

@mathiasvr
Copy link
Contributor

Is this faster than buble?

@feross
Copy link
Member Author

feross commented Sep 15, 2019

1.59s for babel vs 0.82s for buble. I think I'd rather be use babel just to be consistent with the majority of the ecosystem, even though it takes a bit longer to build.

@mathiasvr
Copy link
Contributor

I’m leaning more towards buble because of speed, but I can see it doesn’t make big difference here.

What exactly becomes more consistent?
I mean is there some obvious drawbacks to using buble?

@feross
Copy link
Member Author

feross commented Sep 15, 2019

I don't feel super strongly, but babel has these advantages:

  • Most folks in the React ecosystem use it
  • Lets us target just the transformations we want to apply. In this case, we transform only the JSX and don't touch any other part of the code.

@mathiasvr
Copy link
Contributor

Applying JSX transformations exclusively sounds great, but in this case I prefer buble simply because it's faster.

I'm fine either way.

Copy link
Contributor

@hicom150 hicom150 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hicom150
Copy link
Contributor

Given that buble seems to change to maintenance only mode bublejs/buble#220 I think that it is the correct time to make the transition to babel 😅

This way we can target just the JSX tranformation. We don't use any other cutting edge JS features that require compilation, nor should we in the future.
@feross feross merged commit 969d71a into master Nov 18, 2020
@feross feross deleted the babel branch November 18, 2020 02:41
@feross
Copy link
Member Author

feross commented Nov 18, 2020

Thanks for the review, @hicom150. I just rebased this and merged it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants