Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test setup #1657

Merged
merged 4 commits into from
Sep 6, 2019
Merged

Conversation

hicom150
Copy link
Contributor

It seems that with the update to [email protected]

app.setPath('userData', config.CONFIG_PATH)

fails unless we set

chromeDriverArgs: [`--user-data-dir=${userDataDir}`],

in integration test setup.

@feross
Copy link
Member

feross commented Aug 18, 2019

@hicom150 Thanks for sending this PR!

For some reason, the PR is showing a ton of commits that are not part of the PR. I think you might need to rebase on master. You can do this with git checkout master, then git pull, then switch back to your feature branch with git checkout update_spectron, and then git rebase master. Then you can force push your changes to your remote branch with git push origin update_spectron -f.

If it's not too much trouble, can you give that a try?

@hicom150 hicom150 changed the base branch from greenkeeper/spectron-8.0.0 to master August 19, 2019 18:13
@hicom150
Copy link
Contributor Author

Sorry I made a mess with this PR 😅
I think I have solved now. Thank you for your advises 👍

@feross feross added this to the 0.21.0 milestone Sep 5, 2019
@feross feross merged commit ac9b79c into webtorrent:master Sep 6, 2019
@feross
Copy link
Member

feross commented Sep 6, 2019

Glad that I could be helpful :) This PR looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants