Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer const over let #1497

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Prefer const over let #1497

merged 1 commit into from
Oct 11, 2018

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Oct 10, 2018

In order to comply with this new standard rule ☺️

standard/eslint-config-standard#133

@welcome
Copy link

welcome bot commented Oct 10, 2018

🙌 Thanks for opening this pull request! You're awesome.

Copy link
Contributor

@mathiasvr mathiasvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Borewit Borewit self-requested a review October 11, 2018 06:42
@mathiasvr mathiasvr merged commit aef5669 into webtorrent:master Oct 11, 2018
@welcome
Copy link

welcome bot commented Oct 11, 2018

🎉 Congrats on getting your first pull request landed!

@LinusU LinusU deleted the prefer-const branch October 11, 2018 17:18
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants