Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse media extensions #1450

Merged
merged 2 commits into from
Aug 15, 2018
Merged

Reuse media extensions #1450

merged 2 commits into from
Aug 15, 2018

Conversation

Borewit
Copy link
Member

@Borewit Borewit commented Aug 13, 2018 •
edited
Loading

Share declaration of media-file-extension per media category (audio, video & image).

Add additional file extensions:

Borewit added 2 commits August 13, 2018 21:35
@Borewit
Ensure consistency between extension-categories, between torrent-play…
c2a38bd 
…er and torrent-poster.

Add additional audio-file-extensions.
@Borewit
Merge branch 'master' into reuse-media-extensions
8749135 
# Conflicts:
#	src/renderer/lib/torrent-poster.js
@Borewit Borewit requested a review from codealchemist August 13, 2018 19:51
@Borewit Borewit self-assigned this Aug 13, 2018
codealchemist
codealchemist approved these changes Aug 15, 2018
View reviewed changes
Copy link
Contributor

@codealchemist codealchemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to try the new extensions but the changes are looking good.
Nice reusing of the media extensions!

I did a quick sanity check and playback is working fine.
Thanks!

This was referenced Aug 15, 2018
Merged
Closed
DiegoRBaquero
DiegoRBaquero approved these changes Aug 15, 2018
View reviewed changes
Copy link
Member

@DiegoRBaquero DiegoRBaquero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, makes sense.

LGTM

@DiegoRBaquero DiegoRBaquero merged commit 109accd into master Aug 15, 2018
@DiegoRBaquero DiegoRBaquero deleted the reuse-media-extensions branch August 15, 2018 18:13
@lock lock bot locked as resolved and limited conversation to collaborators Nov 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DiegoRBaquero DiegoRBaquero DiegoRBaquero approved these changes

@codealchemist codealchemist codealchemist approved these changes

Assignees

@Borewit Borewit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Borewit @codealchemist @DiegoRBaquero