[Low-priority] Minutes section of hour-long times formatted without leading zero #1438
Labels
Comments
|
Don't know this codebase very well, but it seems like this issue is here? I think it should be |
|
Looks like you nailed the problem. |
|
Cool, I'll open a PR |
BenMusch
added a commit
to BenMusch/webtorrent-desktop
that referenced
this issue
Jul 21, 2018
Fixes webtorrent#1438 The if statement was testing the opposite of the case it was supposed to test. Changing `>` to `<=` would fix the issue, but there's no reason to even have the conditional to begin with, since `zeroPad(2, 10) === '10'`
|
@Borewit actually I think that wasn't the problem -- that if condition should be checking if there are under 9 minutes total, so that a 9-minute time is displayed as That probably is still the source of the bug, but I'd need to look things over again before fixing it |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
bnjmnt4n
added a commit
that referenced
this issue
Nov 4, 2018
The minutes field should be zero-padded as long as the playback media is longer than 9 minutes (including hours). Fixes #1438.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of WebTorrent Desktop?
0.19.0
What operating system and version?
Fedora 27
What did you do?
Opened a torrent longer than 1 hour, started watching from the beginning
What did you expect to happen?
The remaining time would be formatted as
2:08:33What actually happened?
Remaining time was formatted as
2:8:33The text was updated successfully, but these errors were encountered: