Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use object shorthand for properties #341

Merged
merged 1 commit into from
May 17, 2020

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Apr 25, 2020

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain: lint update

What changes did you make? (Give an overview)

I started using object shorthand for properties, that is, I changed peerId: peerId to peerId.

Which issue (if any) does this pull request address?

standard/eslint-config-standard#166

Is there anything you'd like reviewers to focus on?

n/a


Compatibility: This syntax works on Node.js 4.x and up, and this package declares Node.js 10.x as the minimum supported version ✅

Copy link
Member

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feross feross merged commit 04dd528 into webtorrent:master May 17, 2020
@LinusU LinusU deleted the object-shorthand branch May 18, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants