Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up WebSocket.createServer() and WebSocket.connect() #925

Closed
wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Dec 6, 2016

This cleans up the factory functions WebSocket.createServer() and WebSocket.connect().

Put this in a PR because to be honest I would like to remove them but I would like to hear what other collaborators think before doing that.

@3rd-Eden
Copy link
Member

3rd-Eden commented Dec 7, 2016

People should just use the default API's. Our current master is already breaking a shit ton of things so we might as well nuke this to pieces as well

@3rd-Eden 3rd-Eden closed this Dec 7, 2016
@lpinca lpinca deleted the cleanup/factory-functions branch December 7, 2016 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants