Allow ws to provide a fallback when bundling for the browser #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kalin Kostov <[email protected]>
1 task
lpinca
approved these changes
Feb 13, 2023
1Lucas1apk
added a commit
to Ecliptia/moonlink.js
that referenced
this pull request
Mar 7, 2023
<h3>Snyk has created this PR to upgrade ws from 8.12.0 to 8.12.1.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-02-13.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>ws</b></summary>
<ul>
<li>
<b>8.12.1</b> - <a
href="https://snyk.io/redirect/github/websockets/ws/releases/tag/8.12.1">2023-02-13</a></br><h1>Bug
fixes</h1>
<ul>
<li>Added <code>browser</code> condition to package.json (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1582054161" data-permission-text="Title is private"
data-url="websockets/ws#2118"
data-hovercard-type="pull_request"
data-hovercard-url="/websockets/ws/pull/2118/hovercard"
href="https://snyk.io/redirect/github/websockets/ws/pull/2118">#2118</a>).</li>
</ul>
</li>
<li>
<b>8.12.0</b> - <a
href="https://snyk.io/redirect/github/websockets/ws/releases/tag/8.12.0">2023-01-07</a></br><h1>Features</h1>
<ul>
<li>Added support for <code>utf-8-validate@6</code> (<a
class="commit-link" data-hovercard-type="commit"
data-hovercard-url="https://github.com/websockets/ws/commit/ff63bba37fc0c052a609c7db88cc6d47bfc320e7/hovercard"
href="https://snyk.io/redirect/github/websockets/ws/commit/ff63bba37fc0c052a609c7db88cc6d47bfc320e7"><tt>ff63bba</tt></a>).</li>
</ul>
<h1>Other notable changes</h1>
<ul>
<li><a href="https://nodejs.org/api/buffer.html#bufferisutf8input"
rel="nofollow"><code>buffer.isUtf8()</code></a> is now used instead of
<code>utf-8-validate</code> if available<br>
(<a class="commit-link" data-hovercard-type="commit"
data-hovercard-url="https://github.com/websockets/ws/commit/42d79f60efb739b349b84b020c9d0ee062150633/hovercard"
href="https://snyk.io/redirect/github/websockets/ws/commit/42d79f60efb739b349b84b020c9d0ee062150633"><tt>42d79f6</tt></a>).</li>
</ul>
</li>
</ul>
from <a href="https://snyk.io/redirect/github/websockets/ws/releases">ws
GitHub release notes</a>
</details>
</details>
<details>
<summary><b>Commit messages</b></summary>
</br>
<details>
<summary>Package name: <b>ws</b></summary>
<ul>
<li><a
href="https://snyk.io/redirect/github/websockets/ws/commit/a04578e36611998d089fbb7c6057d1363a5d5754">a04578e</a>
[dist] 8.12.1</li>
<li><a
href="https://snyk.io/redirect/github/websockets/ws/commit/0d114ef48d8baca790733dd2bce23938dd08cb10">0d114ef</a>
[pkg] Add browser condition (#2118)</li>
<li><a
href="https://snyk.io/redirect/github/websockets/ws/commit/2862c2fef1064940c1deb9c4aa961cb76c279feb">2862c2f</a>
[doc] Add error handlers to examples and code snippets</li>
</ul>
<a
href="https://snyk.io/redirect/github/websockets/ws/compare/a3214d31b63acee8e31065be9f5ce3dd89203055...a04578e36611998d089fbb7c6057d1363a5d5754">Compare</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJiNjcwZjRkMi02ZTg1LTQ3NjEtYTFjMy1hNjZhMGQ2Y2FlYmIiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImI2NzBmNGQyLTZlODUtNDc2MS1hMWMzLWE2NmEwZDZjYWViYiJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/011studios/project/75a7828b-4669-4519-a8eb-2f240531fca3?utm_source=github&utm_medium=referral&page=upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/011studios/project/75a7828b-4669-4519-a8eb-2f240531fca3/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/011studios/project/75a7828b-4669-4519-a8eb-2f240531fca3/settings/integration?pkg=ws&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"b670f4d2-6e85-4761-a1c3-a66a0d6caebb","prPublicId":"b670f4d2-6e85-4761-a1c3-a66a0d6caebb","dependencies":[{"name":"ws","from":"8.12.0","to":"8.12.1"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/011studios/project/75a7828b-4669-4519-a8eb-2f240531fca3?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"75a7828b-4669-4519-a8eb-2f240531fca3","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-02-13T20:38:37.660Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "browser" property to "exports", which mimics the default behaviour already present by: "browser": "browser.js"
Signed-off-by: Kalin Kostov [email protected]