Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browserDetails.version returns string after PR#1150 #1151

Closed
2 of 3 tasks
xingri opened this issue Mar 28, 2024 · 1 comment · Fixed by #1152
Closed
2 of 3 tasks

browserDetails.version returns string after PR#1150 #1151

xingri opened this issue Mar 28, 2024 · 1 comment · Fixed by #1152

Comments

@xingri
Copy link
Contributor

xingri commented Mar 28, 2024 •
edited
Loading

  • I have provided steps to reproduce (e.g. a link to a jsfiddle)
  • I have provided browser name, version and adapter.js version
  • This issue only happens when adapter.js is used

Note: If the checkboxes above are not checked (which you do after the issue is posted), the issue will be closed.

Versions affected

**Chrome and Edge Browser all versions

**adapter.js after PR#1150

Description

browserDetails.version returns string after PR#1150
xingri added a commit to xingri/adapter that referenced this issue Mar 28, 2024
@xingri
Update browserDetails.version to return int
1ad0a40 
fixes webrtcHacks#1151
@xingri xingri mentioned this issue Mar 28, 2024
Merged
xingri added a commit to xingri/adapter that referenced this issue Mar 28, 2024
@xingri
Update browserDetails.version to return int
65038a4 
fixes webrtcHacks#1151
@fippo
Copy link
Member

fippo commented Mar 28, 2024

Fixed in 9.0.1, thank you!

fippo added a commit that referenced this issue Mar 29, 2024
@fippo
test: fix unit test to have a string version in userAgentData
48738e0 
which would have prevented #1151
@fippo fippo mentioned this issue Mar 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update browserDetails.version to return int xingri/adapter
2 participants
@fippo @xingri