Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceWorker and Reproducibility Improvements #17

Merged
merged 6 commits into from
Nov 4, 2019
Merged

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Nov 4, 2019

for wombat.js based replay:

  • If loading from SW, override unregister() to prevent unregistering existing SW in the replay

reproducibility:

  • timezone: override Date.getTimeZoneOffset(), Date.toString(), Date.toTimeString() for consistent replay
  • referrer: set referrer to empty for top replay frame (otherwise maybe top-frame or custom based on embed), or rewrite existing referrer for nested frame
  • URL parsing: use URL for parser if available, fallback to anchor tag if not. set origin to null if no host (safari uses :// by default)
  • support blob: urls for replay frame, don't rewrite

…er' with fake object to avoid interfering with existing sw
- use 'new URL' for parsing instead of 'a' tag if available
- ensure origin is "null" if host is empty (safari sometimes uses '://')
@ikreymer ikreymer merged commit d523765 into master Nov 4, 2019
@ikreymer ikreymer deleted the sw-override branch November 4, 2019 21:28
ikreymer added a commit to webrecorder/pywb that referenced this pull request Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant