Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix utf-8 encoding #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomeksporczyk
Copy link

No description provided.

@ikreymer
Copy link
Member

ikreymer commented Jun 1, 2022

Hmm, seems like this should stay as ascii, as it is UTF-8 encoded string but %-encoded value, which should always be ascii.
Have you encountered an issue with this that this PR fixes?

@mw0000
Copy link

mw0000 commented Jun 1, 2022

Hmm, seems like this should stay as ascii, as it is UTF-8 encoded string but %-encoded value, which should always be ascii. Have you encountered an issue with this that this PR fixes?

this actually solves the problem with converting old ARC to WARC (#140), I tested the resulting files via warcio index and warcio extract and got the correct files from payload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants