-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Replay Bug]: Encoding of URL parameter §ion to §ion prevents page from being displayed #323
Comments
Can you provide a specific example where this happens? You can email us directly if you don't want to make it public. |
I was able to repro the error in the escape error in the 404 page, but not the actual loading. |
Hey, I don't have access to the original archive right now sorry. From what I remember, it starts when you navigate from a page using a button on the actual site. So I assume it might be to do with href/setting the URL using JS. Once you've encountered the broken version once, it remains despite using the side panel. Should be able to get the file on Wednesday and then I'll try send you a copy without any sensitive info in. |
- escape URL on not found page, partial fix for webrecorder/replayweb.page#323 - hashiterator: more efficient use of createSHA256(), init on first use, unreference when done, catch error on init
- escape URL on not found page, partial fix for webrecorder/replayweb.page#323 - hashiterator: more efficient use of createSHA256(), init on first use, unreference when done, catch error on init
- escape URL on not found page, partial fix for webrecorder/replayweb.page#323 - hashiterator: more efficient use of createSHA256(), init on first use, unreference when done, catch error on init
Fidelity improvements (via wabac.js and wombat): - fixes ebay carousel #326 (via wombat) - partial fix to error page escaping #323 (via wabac) - fixes to reddit pages #317 - fixes to twitter/x replay (via wabac / wombat) Build improvements: - run mkdocs gh-deploy --force in gh action, instead of publish-docs to avoid accidental updates - auto install ruffle from download script, remove from git, add 'update-ruffle' script - update to latest ruffle which doesn't inject setImmeidate/ clearImmediate to avoid interference with certain sites, fixing fidelity on some sites (including twitter/x) - remove unused src/sw.ts - deps: wabac.js to 2.18.2 bump to 2.0.1
ReplayWeb.page Version
v2.0.0
What did you expect to happen? What happened instead?
When viewing a page with "§" in the URL, the site will convert the "§" into the character §, which then errors as it cannot find the page.
In this image, the correct URL is shown in the page list and URL bar. The incorrect URL is shown on the error page.
Additionally, using & does not seem to work either despite the correct URL being shown:
Step-by-step reproduction instructions
Additional details
Note: this happens with basically any unicode character, for example:
😂
The text was updated successfully, but these errors were encountered: