Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit Lookup Fix for Empty Records #530

Merged
merged 1 commit into from
Jan 11, 2020
Merged

Revisit Lookup Fix for Empty Records #530

merged 1 commit into from
Jan 11, 2020

Conversation

ikreymer
Copy link
Member

Description

If a revisit record has the empty digest, don't attempt to lookup the original!

Motivation and Context

Fix for ukwa/ukwa-pywb#53

Screenshots (if appropriate):

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@ikreymer
revisit lookup fix (possible fix for ukwa/ukwa-pywb#53)
7850852 
- if a revisit record has empty hash, don't attempt to lookup an original, simply use with empty payload
@ikreymer ikreymer merged commit fb8aa7c into develop Jan 11, 2020
@ikreymer ikreymer deleted the no-empty-revisit branch January 18, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ikreymer