Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply fuzzy match if url prefix and regex match #524

Merged
merged 1 commit into from
Dec 21, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pywb/warcserver/index/fuzzymatcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def get_fuzzy_match(self, urlkey, url, params):
m = rule.regex.search(urlkey)
groups = m and m.groups()

if not groups:
if groups is None:
continue

matched_rule = rule
Expand All @@ -99,7 +99,7 @@ def get_fuzzy_match(self, urlkey, url, params):

# support matching w/o query if no additional filters
# don't include trailing '?' if no filters and replace_after '?'
no_filters = (filters == {'urlkey:'}) and (matched_rule.replace_after == '?')
no_filters = (not filters or filters == {'urlkey:'}) and (matched_rule.replace_after == '?')

inx = url.find(matched_rule.replace_after)
if inx > 0:
Expand Down