Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization and Banner Update #517

Merged
merged 3 commits into from
Nov 11, 2019
Merged

Localization and Banner Update #517

merged 3 commits into from
Nov 11, 2019

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Nov 7, 2019

Description

Merges additional functionality for banner: calendar link, localization options from UKWA branch
Localization: Adds babel and core loc functionality to core (disabled by default).
Does not yet add any localizations.

Motivation and Context

The banner can now be used as is by UKWA, with just different stylesheets and localization options.
In place for addressing ukwa/ukwa#33

Screenshots (if appropriate):

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

…ed by wombat via prototype

update to latest wombat
- show 'view all captures' link if not live
- optional logo
- loc options, if available
- banner options set via window.banner_info in banner.html

loc: add init_loc() to templateview
- loc available if config options set
- tests: add tests for loading loc messages
@ikreymer ikreymer merged commit 0d819aa into develop Nov 11, 2019
@ikreymer ikreymer deleted the loc-and-banner branch January 30, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant