Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation from sdist fails #558

Closed
jayvdb opened this issue Apr 22, 2020 · 0 comments · Fixed by #559
Closed

Installation from sdist fails #558

jayvdb opened this issue Apr 22, 2020 · 0 comments · Fixed by #559

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Apr 22, 2020

Describe the bug

setup.py fails because requirements.txt is not included in the sdist

Steps to reproduce the bug

  1. Fetch and unpack sdist from PyPI
  2. Run setup.py bdist_wheel (or similar)

Expected behavior

setup.py should run setuptools
jayvdb added a commit to jayvdb/pywb that referenced this issue Apr 22, 2020
@jayvdb
MANIFEST.in: Create
4305525 
Fixes webrecorder#558
@jayvdb jayvdb mentioned this issue Apr 22, 2020
Merged
jayvdb added a commit to jayvdb/pywb that referenced this issue Apr 22, 2020
@jayvdb
MANIFEST.in: Create
b6afd67 
Fixes webrecorder#558
ikreymer pushed a commit that referenced this issue Apr 30, 2020
@jayvdb
MANIFEST.in: Create (#559)
be90e06 
Fixes #558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sdist jayvdb/pywb
1 participant
@jayvdb