refactor: Migrate LiteElements #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuaYoo
commented
Nov 12, 2024
| @@ -39,7 +39,8 @@ type CloseMessage = Message & { | |||
| @localized() | |||
| export class Screencast extends BtrixElement { | |||
| static baseUrl = `${window.location.protocol === "https:" ? "wss" : "ws"}:${ | |||
| process.env.WEBSOCKET_HOST || window.location.host | |||
| // Defined in webpack: | |||
| window.process.env.WEBSOCKET_HOST || window.location.host | |||
There was a problem hiding this comment.
Updated to work with test runner
emma-sg
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1984
Changes
LiteElements toBtrixElement:App(<browsetrix-home>)Admin(<btrix-home)Dashboard(<btrix-dashboard>)LogInPage(<btrix-log-in>)btrix-inputwithsl-inputsince password managers should work now.Manual testing
Context
This will allow usage of lit reactive controllers in more components, for example to react to lit locale changes.