Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add details on translation status #2139

Merged
merged 13 commits into from
Nov 12, 2024
Merged

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Nov 11, 2024

Resolves #2136

Changes

  • Hides language dropdown from log in page if there's less than 2 languages specified in translatedLocales
  • Updates user language preference beta badge text
  • Adds link to translation contribution docs
  • Refactors component name

Screenshots

Page Image/video
Account Settings Screenshot 2024-11-12 at 8 51 37 AM
Account Settings - beta badge hover Screenshot 2024-11-12 at 8 52 10 AM

Follow-ups

We should add browser preferred languages to the list in order to support #2143

@SuaYoo SuaYoo changed the title feat: Maintain separate list of translated languages feat: Add details on translation status Nov 11, 2024
@SuaYoo SuaYoo marked this pull request as ready for review November 12, 2024 00:01
@Shrinks99
Copy link
Member

It occurs to me... As sparkles have been completely co-opted by AI, maybe we should use the flask icons instead? These were supposed to be in Bootstrap 1.11 but never actually got added :\

I can commit them to this branch under our custom icons for now?

@SuaYoo
Copy link
Member Author

SuaYoo commented Nov 12, 2024

It occurs to me... As sparkles have been completely co-opted by AI, maybe we should use the flask icons instead? These were supposed to be in Bootstrap 1.11 but never actually got added :\

I can commit them to this branch under our custom icons for now?

Ah yeah, that'd be great!

@SuaYoo SuaYoo marked this pull request as draft November 12, 2024 16:20
@SuaYoo SuaYoo marked this pull request as ready for review November 12, 2024 16:53
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Made a couple small tweaks to beta tooltip text size & spacing where it's used.

@SuaYoo SuaYoo force-pushed the frontend-manual-enable-language branch from 469e301 to 0dc9442 Compare November 12, 2024 19:48
@SuaYoo SuaYoo merged commit ab9edfa into main Nov 12, 2024
2 checks passed
@SuaYoo SuaYoo deleted the frontend-manual-enable-language branch November 12, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable individual languages + workflow improvements
3 participants