Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Auto-commit extracted localization strings #2089

Merged
merged 7 commits into from
Sep 30, 2024

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Sep 23, 2024

Resolves #1416

Changes

Removes localize:extract from pre-commit hook and commits changes from localize:extract in frontend PR build check.

Example commit: 89d04a2

Also removes the unused format check, it shouldn't be much of an issue since 1. it wasn't working and 2. we're formatting in the pre-commit hook.

@SuaYoo SuaYoo marked this pull request as ready for review September 23, 2024 17:02
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for setting this up!

Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this!

@SuaYoo SuaYoo force-pushed the gh-auto-commit-localized-strings branch from 89d04a2 to 5c42dec Compare September 30, 2024 17:41
@SuaYoo SuaYoo merged commit 08aa2f8 into main Sep 30, 2024
1 check passed
@SuaYoo SuaYoo deleted the gh-auto-commit-localized-strings branch September 30, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization workflow improvements
3 participants