stats recompute fixes: #2022
Merged
stats recompute fixes: #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ikreymer
commented
Aug 14, 2024
ikreymer
commented
- fix stats_recompute_last() and stats_recompute_all() to not update the lastCrawl* properties of a crawl workflow if a crawl is running, as those stats now point to the running crawl
- refactor _add_running_curr_crawl_stats() to make it clear stats only updated if crawl is running
- stats_recompute_all() change order to ascending to actually get last crawl, not first!
- fix stats_recompute_last() and stats_recompute_all() to not update the lastCrawl* properties of a crawl workflow if a crawl is running, as those stats now point to the running crawl - refactor _add_running_curr_crawl_stats() to make it clear stats only updated if crawl is running - stats_recompute_all() change order to ascending to actually get last crawl, not first!
tw4l
approved these changes
Aug 26, 2024
backend/btrixcloud/crawlconfigs.py
Outdated
| @@ -596,6 +593,8 @@ async def stats_recompute_last(self, cid: UUID, size: int, inc_crawls: int = 1): | |||
| update_query["lastCrawlSize"] = sum( | |||
| file_.get("size", 0) for file_ in last_crawl.get("files", []) | |||
| ) | |||
| update_query["lastCrawlStopping"] = last_crawl.get("stopping", False) | |||
There was a problem hiding this comment.
Should this always be False like isCrawlRunning? Otherwise if the crawl were still stopping it would still be in a running state I think.
There was a problem hiding this comment.
yeah, i guess this would reflect if last crawl was stopped manually, though that may be confusing since its referring to last crawl..
There was a problem hiding this comment.
ok, updated as suggested - otherwise too confusing - if we do need that for some reason, could add a lastCrawlStopped field..
backend/btrixcloud/crawlconfigs.py
Outdated
| @@ -972,6 +960,8 @@ async def stats_recompute_all(crawl_configs, crawls, cid: UUID): | |||
| update_query["lastStartedByName"] = last_crawl.get("userName") | |||
| update_query["lastCrawlState"] = last_crawl.get("state") | |||
| update_query["lastCrawlSize"] = last_crawl_size | |||
| update_query["lastCrawlStopping"] = last_crawl.get("stopping", False) | |||
There was a problem hiding this comment.
Same as above, I think this should always be False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.