Add frontend localization support #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuaYoo
force-pushed
the
frontend-localization
branch
from
7538b61
to
4d9650e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#17) Adds localization support and basic locale picker for testing.
Demo (watch the "Log In" button in upper right):
How it works: https://github.com/ikreymer/browsertrix-cloud/blob/eba888f51372661d3a000b0b033b1a54f87ff5c1/frontend/README.md#localization
Testing
yarnyarn start-devand try updating languages with locale picker. I'm using Korean as an example since I can verify the translation.If you're using VSCode and you see a type error around
DisplayNames, check if VSCode is using typescript <4.5.2 and upgrade to match if necessary.TODOs left open to address in the future: