QA page details #1656
Merged
QA page details #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- improves overflow issues at smaller screen sizes - adds icons to buttons - updates text & layout to match mocks - changes primary button & button options depending on if there's a qa run available - adds a loading state for qa run status & buttons - updates <btrix-crawl-status> with a `type` param allowing for crawls, uploads, and QA runs
SuaYoo
reviewed
Apr 8, 2024
Change "Ready for Review" to "Complete" Co-authored-by: sua yoo <[email protected]>
- Paginates QA tab page list - Sort QA tab page list by title, URL, comments, and approval; displays all sortable fields - Standardizes page "reviews" -> "approvals" - Standardizes crawl review rating labels - Displays only latest comment in review page list --------- Co-authored-by: emma <[email protected]>
- improves overflow issues at smaller screen sizes - adds icons to buttons - updates text & layout to match mocks - changes primary button & button options depending on if there's a qa run available - adds a loading state for qa run status & buttons - updates <btrix-crawl-status> with a `type` param allowing for crawls, uploads, and QA runs
Change "Ready for Review" to "Complete" Co-authored-by: sua yoo <[email protected]>
- Paginates QA tab page list - Sort QA tab page list by title, URL, comments, and approval; displays all sortable fields - Standardizes page "reviews" -> "approvals" - Standardizes crawl review rating labels - Displays only latest comment in review page list --------- Co-authored-by: emma <[email protected]>
SuaYoo
force-pushed
the
frontend-qa-overview-page
branch
from
4ee12a3
to
6d18554
Compare
…order/browsertrix-cloud into frontend-qa-overview-page
Related #1663 Increases rating scale from 3 to 5. --------- Co-authored-by: emma <[email protected]>
Partially addresses #1651 ### Changes - Disables review actions if analysis is running - Enables downloading run - Enables stopping and canceling runs - Minor refactor to create and implement `btrix-menu-item-link` for download menu option - Hides canceled QA runs from dropdown --------- Co-authored-by: emma <[email protected]>
Shrinks99
reviewed
Apr 16, 2024
This comment was marked as resolved.
This comment was marked as resolved.
…order/browsertrix-cloud into frontend-qa-overview-page
|
Added tab and alert message: 
|
- make analysis run naming consistent - allow deletion dialog to always render, allowing for animation on initial enter - make button styling in dialog consistent, using filled danger style for delete and neutral style for cancel
…order/browsertrix-cloud into frontend-qa-overview-page
|
@SuaYoo re: tab and alert messages, should we unify the styling of the tag and alert warnings? I feel like it'd make sense for both to use the same amber colours and borders etc. cc @Shrinks99 |
Yep that should be pretty quick change to |
SuaYoo
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
<btrix-crawl-status>with atypeparam allowing for crawls, uploads, and QA runs<btrix-alert>to match<sl-tag>stylingFeatures
I'd like to refactor a bunch of this code in a follow-up PR once this is merged.