Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Merge workflow job types into additional scope types #2073

Closed
SuaYoo opened this issue Sep 11, 2024 · 0 comments · Fixed by #2068
Closed

[Feature]: Merge workflow job types into additional scope types #2073

SuaYoo opened this issue Sep 11, 2024 · 0 comments · Fixed by #2068
Assignees
@SuaYoo
Labels
enhancement New feature or request front end Requires front end dev work ui/ux This issue requires UI/UX work

Comments

@SuaYoo
Copy link
Member

SuaYoo commented Sep 11, 2024

What change would you like to see?

I'd like to be able to change scopes after creating a workflow.

Context

Workflow job types cannot be changed after creation. The repercussion of committing to a job type are unclear since we don't show the job type after creation. This might be an unnecessary constraint on the end user if we provide them with additional crawl scopes and do not reset workflow fields when the scope type changes.
@SuaYoo SuaYoo added the enhancement New feature or request label Sep 11, 2024
@SuaYoo SuaYoo self-assigned this Sep 11, 2024
@ikreymer ikreymer moved this from Triage to Todo in Webrecorder Projects Sep 11, 2024
@SuaYoo SuaYoo mentioned this issue Sep 11, 2024
Merged
@SuaYoo SuaYoo added ui/ux This issue requires UI/UX work front end Requires front end dev work labels Sep 11, 2024
@SuaYoo SuaYoo moved this from Todo to Implementing in Webrecorder Projects Sep 11, 2024
ikreymer pushed a commit that referenced this issue Sep 25, 2024
@SuaYoo
feat: Merge workflow job types (#2068)
612bbb6 
Resolves #2073

### Changes

- Removes "URL List" and "Seeded Crawl" job type distinction and adds as
additional crawl scope types instead.
- 'New Workflow' button defaults to Single Page
- 'New Workflow' dropdown includes Page Crawl (Single Page, Page List, In-Page Links) and Site Crawl (Page in Same Directory, Page on Same Domain, + Subdomains and Custom Page Prefix)
- Enables specifying `DOCS_URL` in `.env`
- Additional follow-ups in #2090, #2091
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuaYoo SuaYoo

Labels
enhancement New feature or request front end Requires front end dev work ui/ux This issue requires UI/UX work
Projects
Webrecorder Projects
Status: Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Merge workflow job types webrecorder/browsertrix
1 participant
@SuaYoo