Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure links added via behaviors also get processed #478

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Feb 28, 2024

Requires webrecorder/browsertrix-behaviors#69 / browsertrix-behaviors 0.5.3, which will add support for behaviors to add links.

Simplify adding links by simply adding the links directly, instead of batching to 500 links. Errors are already being logged in queueing a new URL fails.

@ikreymer ikreymer requested a review from tw4l February 28, 2024 20:09
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to revise the PR description to remove the reference to flushLinks when squashing + merging, otherwise looks good! Nice simplification.

@ikreymer ikreymer merged commit 184f4a2 into dev-1.0.0 Feb 29, 2024
4 checks passed
@ikreymer ikreymer deleted the flush-links-callback branch February 29, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants