Page Resources: Include Cached Resources #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age resources dict, even if not written to WARC
tw4l
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Tested with a https://webrecorder.net crawl - pages like /about have cached resources written into the pageinfo record after the change.
…he resources on the page
|
Also added tests to verify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure cached resources (that are not written to WARC) are still included in the
url:pageinfo:...records. This will make it easier to track which resources are actually loaded from a given page.To test, run crawl for a site with cached resources, such as https://webrecorder.net/ and verify that each page pageinfo includes all the resources.