Fix potential for pending list never being processed #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s always called before numPending(): this could result in a loop where pendings urls are not being processed in worker loop since only numPending() is called
|
And I agree, porting to 0.12.2 seems like a good idea :) |
Will open a follow-up PR for 0.12.2 |
ikreymer
added a commit
that referenced
this pull request
Nov 14, 2023
Backport of #433 to 0.12.x. Bump version to 0.12.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an optimization, numPending() call assumed that queueSize() would be called to update cached queue size. However, in the current worker code, this is not the case. Remove cacheing queue size and just check queue size in numPending(), to ensure pending list is always processed.
Perhaps want to port this to a 0.12.2 release, as this addresses an edge case after exclusions where pending URLs remain but are not reprocessed.